This repository was archived by the owner on Jul 28, 2023. It is now read-only.
SSR: Don't process directives in inner blocks#227
Closed
ockham wants to merge 1 commit intomain-wp-directives-pluginfrom
Closed
SSR: Don't process directives in inner blocks#227ockham wants to merge 1 commit intomain-wp-directives-pluginfrom
ockham wants to merge 1 commit intomain-wp-directives-pluginfrom
Conversation
Collaborator
Author
|
On second glance, I've noticed that with this patch applied on top of #141 and tested with the Movies Demo, we're actually missing one Closing. |
ockham
deleted the
fix/repeated-processing-of-directives-in-nested-blocks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #215. See #215 (comment) for the rationale.
Since we are hooking
wp_process_directivesintorender_block, it gets run repeatedly on markup inside nested inner blocks (once for each level of block nesting around a given piece of markup).