This repository was archived by the owner on Dec 11, 2017. It is now read-only.
Enable addon goodies #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Auto-closing tags and brackets should help users write valid code to start with. All of the add-ons enabled here should help with reducing errors or at least improve the quality of code and the UX. |
Member
Author
|
Though the styling needs improvement. |
| } | ||
| } elseif ( false !== strpos( $type, 'xml' ) || in_array( $extension, array( 'xml', 'svg' ), true ) ) { | ||
| $settings['codemirror']['mode'] = 'application/xml'; | ||
| $settings['codemirror'] = array_merge( $settings['codemirror'], array( |
Collaborator
There was a problem hiding this comment.
Should this be wp_parse_args instead?
Member
Author
There was a problem hiding this comment.
I don't think it is necessary because wp_parse_args is only really useful if a user is supplying params via query string like mode=application/xml, but that's not being done here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.