Skip to content
This repository was archived by the owner on Dec 11, 2017. It is now read-only.
This repository was archived by the owner on Dec 11, 2017. It is now read-only.

Combine wp_code_editor_settings() into wp_enqueue_code_editor() #55

@westonruter

Description

@westonruter

For the post editor, there is just wp_enqueue_editor(). The code editor currently has a wp_enqueue_code_editor() function that takes a $settings arg which has the configuration for the desired editor, which is then used to determine which scripts and styles get enqueued. The $settings array is generated by wp_code_editor_settings(). However, having two separate functions may not make sense, and perhaps the arg passed into wp_code_editor_settings() should just be what is passed into wp_enqueue_code_editor().

Additionally, the $context arg that is passed into wp_code_editor_settings() should maybe be cleaned up. If $context['file'] is always required, then maybe it should take a $file arg followed by a $context. Or maybe file shouldn't be required all, and it could accept a type instead, which would make some more sense in the case of Additional CSS and the Custom HTML widget.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions