Review Notes and Refine Notes: Add post type support check#444
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #444 +/- ##
==========================================
Coverage 68.44% 68.44%
Complexity 846 846
==========================================
Files 56 56
Lines 4095 4095
==========================================
Hits 2803 2803
Misses 1292 1292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkotter
left a comment
dkotter
left a comment
There was a problem hiding this comment.
Code looks good here but we did recently merge in a "Refine Notes" experiment and it likely could benefit from the same check so would be great to see that added in this PR. See https://github.com/WordPress/ai/blob/7d9855757b09b087eb5abf0274ab5c0a4bc873d2/src/experiments/refine-notes/index.tsx
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
t-hamano
changed the title
|
Thank you for your review. I have added the same check to the Refine Notes UI. |
github-project-automation
Bot
moved this from Needs review
to Done
in WordPress AI Planning & Roadmap
3 participants
What?
Guards the Review Notes and the Refine Notes editor plugins behind a
PostTypeSupportCheckso it only renders on post types that declare support foreditor.notes.Why?
These UIs were registered globally and rendered in the editor regardless of whether the current post type supports Notes.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.7
Used for: PR description drafting. The code change was authored and reviewed by me.
Testing Instructions
editor.notes(e.g.post), confirm these UIs load as before.editor.notessupport, confirm these UI no longer render in the editor.Screenshots or screencast
Changelog Entry