The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jeffpaul <[email protected]>
Co-authored-by: saarnilauri <[email protected]>
Co-authored-by: dkotter <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: justlevine <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Codecov Report

❌ Patch coverage is 93.57143% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.72%. Comparing base (ae75c40) to head (8a6137a).
⚠️ Report is 1 commits behind head on develop.

@@              Coverage Diff              @@
##             develop     #359      +/-   ##
=============================================
+ Coverage      66.90%   67.72%   +0.81%     
- Complexity       907      959      +52     
=============================================
  Files             59       60       +1     
  Lines           4699     4836     +137     
=============================================
+ Hits            3144     3275     +131     
- Misses          1555     1561       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saarnilauri let us know when this is ready again for review/testing, thanks!

• Guidelines CPT: Changes slug from wp_content_guidelines to wp_guidelines gutenberg#77147

I have updated the post type to match the new slug but keep the legacy slug for < 23.0

• Registers wp_guideline_type taxonomy gutenberg#77156

While the current code works, we need to watch the Gutenberg release process and adjust support as needed.

The support for the guideline taxonomy is now baked in.

1. Currently doesn't work for me. Doing some quick debugging, it appears the Content Guidelines post type stores in a draft state so our query doesn't work. Not sure if there's something I need to do to get those published or if this is expected

Gutenberg's REST controller saves new guideline posts as 'draft' by default. Our query only matched 'publish', silently returning no guidelines for the common case. Now accept both statuses (matching Gutenberg's own get_guidelines_post() behavior) and order by date so the most recent guideline wins when multiple posts exist.

2. We've added a few new Abilities since this was opened and we should look to add guidelines support to those: Content Classification and Meta Descriptions

These new abilities have now guidelines injected to them.

So, everything is ready for your review.

The not yet implemented PR WordPress/gutenberg#77230 in the Gutenberg, requires a larger refactoring and we need to keep tracking it's progress. It might be better to create a new issue related to it.

maybe waiting until Gutenberg 23.0 comes out before merging this, so we can just make that the minimum version we support. But otherwise this looks good to go

Just passing by and saw this. Are we picking up a new dependency in the form of the Gutenberg plugin or is there some availability checking that I'd see if I actually pulled this PR down to review more deeply?

maybe waiting until Gutenberg 23.0 comes out before merging this, so we can just make that the minimum version we support. But otherwise this looks good to go

Just passing by and saw this. Are we picking up a new dependency in the form of the Gutenberg plugin or is there some availability checking that I'd see if I actually pulled this PR down to review more deeply?

It is the latter. We are not including Gutenberg as a dependency within the plugin. This is a progressive enhancement that only runs if the right version of Gutenberg is installed and if the Guidelines experiment is turned on.

Ready for the review