WP 7.0: Remove dependencies and rely on what's in core#271
WP 7.0: Remove dependencies and rely on what's in core#271dkotter merged 11 commits intoWordPress:developfrom
Conversation
…'t use directly anymore
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
felixarntz
left a comment
There was a problem hiding this comment.
@dkotter Mostly looks good! A few comments.
|
Hey @dkotter - I'm curious about the decision to replace the Composer autoloader with our own Was it just because we're no longer requiring any production dependencies, or are there other considerations? Don't see it called out in the ticket. If that was the only reason, then I'd suggest we restore it, we anyway have a build step, and a prebuilt classmap is always going to be work better than live discovery (even if we microptimize by e.g. dropping the extra filesystem call with something like |
I don't feel strongly either way, this was a change request on this PR, see #271 (comment) |
Note
This is the first PR in a set of three. #272 and #275 will come next once this is merged
What?
Partially closes #244
Instead of including a number of dependencies, use what is in WordPress 7.0
Why?
This is the first PR on the path of adding full support for WordPress 7.0 and the new AI Client that is included there. WP 7.0 will include the AI Client and so we no longer need to bundle that.
How?
automattic/jetpack-autoloader,wordpress/mcp-adapterandwordpress/wp-ai-clientdependenciesUse of AI Tools
None
Testing Instructions
This is the first PR in a series that will bring full support to WP 7.0. As such, things aren't in a fully usable state yet. If you test this PR, you should be able to install/activate the plugin on both WP 6.9 and WP 7.0 (no fatals in either) but the plugin won't fully work in either yet
Note
Unit and E2E tests are failing. Those will be fixed up once full 7.0 support is in place.