The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: [email protected].

Co-authored-by: dkotter <[email protected]>
Co-authored-by: pbearne <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.30%. Comparing base (6e60327) to head (79b763e).
⚠️ Report is 8 commits behind head on develop.

@@              Coverage Diff              @@
##             develop     #175      +/-   ##
=============================================
- Coverage      50.45%   50.30%   -0.16%     
- Complexity       379      381       +2     
=============================================
  Files             27       27              
  Lines           1992     1998       +6     
=============================================
  Hits            1005     1005              
- Misses           987      993       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

2. I'd argue the better approach here is an early check to see if the file exists. If not, there's no reason to run any of the code. I think that fixes the issue you're seeing and removes the need for most of the change here

I thought about that, but the function can use an asset.php file

2. I'd argue the better approach here is an early check to see if the file exists. If not, there's no reason to run any of the code. I think that fixes the issue you're seeing and removes the need for most of the change here

I thought about that, but the function can use an asset.php file

Not sure I follow? It does pull the asset.php file from the same location as the asset itself and then it uses that for the dependency array and version. But the main point of these methods is to run wp_enqueue_script|style and if the file we're trying to enqueue doesn't actually exist, seems we'd be better of returning early before any processing

Thanks for the PR! In addition to the previous review, I believe we should also have the check and early bail for enqueue_script().