Ensure the right version of the PHP AI Client is installed#122
Ensure the right version of the PHP AI Client is installed#122jeffpaul merged 1 commit intoWordPress:developfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #122 +/- ##
=============================================
- Coverage 29.37% 28.79% -0.59%
- Complexity 145 153 +8
=============================================
Files 14 14
Lines 885 903 +18
=============================================
Hits 260 260
- Misses 625 643 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Worth noting that in testing with Google Gemini, I'm now getting a timeout error instead of the original 404 error. This will be fixed once a new release of the WP AI Client goes out as the default timeout value was increased in WordPress/wp-ai-client#29. So we could hold on this PR until the 0.2.0 release of the WP AI Client package is ready and then update to that here |
jeffpaul
left a comment
jeffpaul
left a comment
There was a problem hiding this comment.
Let's at least fix this version bump for this and can come back and do another, proper bump when the WP client hits 0.2.0?
2 participants
What?
Ensure the right version of the PHP AI Client is pulled in from the WP AI Client update
Why?
In #118, I updated our composer config to pull in the latest release of the WP AI Client package (0.1.1) instead of pulling in
trunk. This was supposed to pull in the latest release of the PHP AI Client (0.2.1) but it seems that just running thecomposer require wordpress/wp-ai-client:0.1.1command didn't pull in the downstream dependencies so it was still using the 0.2.0 release of that package.How?
Initially tried running
composer updateto bring in everything but there appears to be some conflicts with our PHPCS tools coming out of recent changes made to thedevelopbranch of thephpcompatibility/php-compatibilitypackage. So instead of trying to fix all of those, I rancomposer require wordpress/wp-ai-client:0.1.1 -Wto bring in the updated version of the PHP AI Client package (the-Wflag was the trick here)Testing Instructions
n/a