Skip to content

dev: Bump the PHPStan testing to PHP 8.4 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gziolo merged 1 commit into from
Sep 23, 2025
Merged

dev: Bump the PHPStan testing to PHP 8.4 #82

gziolo merged 1 commit into from
Sep 23, 2025

Conversation

@johnbillion
Copy link
Member

@johnbillion johnbillion commented Sep 22, 2025 •
edited
Loading

PHP unit tests are run on PHP 8.4 so PHPStan should check in the context of 8.4 too.

@codecov
Copy link

codecov bot commented Sep 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.84%. Comparing base (c9abf12) to head (51cb4c0).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files 
@@            Coverage Diff            @@
##              trunk      #82   +/-   ##
=========================================
  Coverage     83.84%   83.84%           
  Complexity       96       96           
=========================================
  Files             8        8           
  Lines           520      520           
=========================================
  Hits            436      436           
  Misses           84       84
Flag Coverage Δ
unit 83.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johnbillion johnbillion marked this pull request as ready for review September 22, 2025 18:30
@github-actions
Copy link

github-actions bot commented Sep 22, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: johnbillion <[email protected]>
Co-authored-by: JasonTheAdams <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

JasonTheAdams
JasonTheAdams approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gziolo gziolo merged commit 409a77e into trunk Sep 23, 2025
35 checks passed
@gziolo gziolo deleted the phpstan-php84 branch September 23, 2025 07:52
@gziolo gziolo added the [Tool] Issues related to development tooling, such as linting, testing, or CI label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonTheAdams JasonTheAdams JasonTheAdams approved these changes

@justlevine justlevine Awaiting requested review from justlevine

Assignees

@johnbillion johnbillion

Labels

[Tool] Issues related to development tooling, such as linting, testing, or CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnbillion @JasonTheAdams @gziolo