WP/GlobalVariablesOverride: add XML documentation#2679
Merged
dingo-d merged 6 commits intoWordPress:developfrom Jan 30, 2026
Merged
WP/GlobalVariablesOverride: add XML documentation#2679dingo-d merged 6 commits intoWordPress:developfrom
dingo-d merged 6 commits intoWordPress:developfrom
Conversation
jrfnl
reviewed
Jan 27, 2026
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks for picking this one up @rodrigoprimo ! Left some comments to consider inline.
Collaborator
Author
|
Thanks for your review, @jrfnl! I implemented your suggestions and proposed two shorter alternatives to the valid title. This PR is ready for another look when you get a chance. |
jrfnl
approved these changes
Jan 29, 2026
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks @rodrigoprimo ! I think this one is ready for merge.
Member
|
Note for the second reviewer: please squash-merge this PR. |
dingo-d
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds XML documentation for the
WordPress.WP.GlobalVariablesOverridesniff.The documentation is based on the work started by @paulopmt1 in #2586. I squashed the original commits and, in a separate commit, made subsequent changes based on the review left in #2586.
I suggest squashing those two commits before merging. I'm opening the PR without doing that to make it easier to tell my changes apart from the original changes.
Suggested changelog entry
N/A
Related issues/external references
Related to: #1722
Supersedes: #2586
Closes #2586