AbstractClassRestrictionsSniff sniffs: add tests for namespaced names #2643
+107
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoprimo
added
Type: Chores/Cleanup
Status: Review ready
and removed
Status: Review ready
labels
Collaborator
Author
|
Moved to draft pending the review of #2620 |
rodrigoprimo
force-pushed
the
more-namespace-tests-2
branch
from
187b5c8 to
420def6
Compare
rodrigoprimo
changed the title
Collaborator
Author
jrfnl
reviewed
Dec 9, 2025
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks @rodrigoprimo for setting this up! Looking good. Just some small remarks to dot the i's and cross the t's.
More tests will be added in a separate file in a subsequent commit.
I opted to add the tests in a separate file as for DeprecatedClassesUnitTest.1.inc the error lines are generated dynamically.
rodrigoprimo
force-pushed
the
more-namespace-tests-2
branch
from
420def6 to
f4099e0
Compare
Collaborator
Author
|
Thanks for your review, @jrfnl. I addressed the points that you raised and, as we discussed, amended the original commits. |
This commit also adds two non-namespaces tests for interfaces as those were missing in the file.
rodrigoprimo
force-pushed
the
more-namespace-tests-2
branch
from
f4099e0 to
a6b8b32
Compare
jrfnl
approved these changes
Dec 9, 2025
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Thanks for making those updates @rodrigoprimo ! All good from me now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for PHPCS 4.0, which changes the tokenization of namespaced names, this PR adds tests with all forms of namespaced function calls (partially qualified, fully qualified, and namespace-relative using the 'namespace' keyword) as well as fully qualified global function calls to the sniffs that extend the
AbstractClassRestrictionsSniffclass when necessary. Some test files already contained part or all of the required tests.For
DeprecatedClasses, I opted to add the tests in a separate file as the error linesDeprecatedClassesUnitTest.1.incare generated dynamically. Since the tests were added to a separate file, I opted to include all possible namespace variations even though a few already exist inDeprecatedClassesUnitTest.1.inc. I didn't want to complicate things by having the namespaced names tests in different files.Suggested changelog entry
N/A