DB/DirectDatabaseQuery: make cache function name matching case-insensitive #2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing this to allow for additional test case files.
…itive The sniff was checking cache function names incorrectly, as it was not considering that PHP function names are case-insensitive, leading to false positives.
jrfnl
approved these changes
Sep 15, 2025
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
LGTM! Good catch @rodrigoprimo !
dingo-d
approved these changes
Sep 16, 2025
Member
|
Should this be re-milestoned due to #2614? |
Member
Yes and I did a bulk re-milestone, so should be okay now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sniff was checking cache function names incorrectly, as it was not considering that PHP function names are case-insensitive, leading to false positives.
Also includes two preparatory commits reorganizing the tests.
Suggested changelog entry
Fixed: WordPress.DB.DirectDatabaseQuery: ensure the sniff handles cache function names in a case-insensitive manner.