Release checklist: add new bullet about checking all PRs are milestoned #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rodrigo and me just noticed that a few PRs which were merged into the `3.2.0` release did not have a milestone attached. We've fixed those now and will fix the changelog too (only one needed a mention, the others were maintenance PRs). This commit just adds a new reminder bullet to verify that all PRs are milestoned before creating the changelog to (hopefully) prevent this from happening again. _Side-note: in other repos I actually have it required check for the milestone being set (can't merge without it), but that would require permission from the WordPress organisation to allow the [app which handles that](https://github.com/scholzj/milestone-check) and that might get complicated..._
GaryJones
approved these changes
Sep 3, 2025
rodrigoprimo
approved these changes
Sep 3, 2025
dingo-d
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rodrigo and me just noticed that a few PRs which were merged into the
3.2.0release did not have a milestone attached. We've fixed those now and will fix the changelog too (only one needed a mention, the others were maintenance PRs).This commit just adds a new reminder bullet to verify that all PRs are milestoned before creating the changelog to (hopefully) prevent this from happening again.
Side-note: in other repos I actually have a required check for the milestone being set (can't merge without it), but that would require permission from the WordPress organisation to allow the app which handles that and that might get complicated...