PHP 8.5 | WP/EnqueuedResourceParameters: prevent deprecation notice for non-standard casts #2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or non-standard casts Four non-standard type casts are going to be deprecated in PHP 8.5. When any of these type casts would be used in the parameter this sniff examines in the "code under scan" and the sniff would be run on PHP 8.5, the non-standard type cast would be executed via the `eval()`, leading to a deprecation notice, which would stop the scan of the file. This commit works around this by always using the "standard" type cast syntax in the code which would be passed to `eval()`. Includes tests.
Member
Author
|
Note: the remaining PHP 8.5 test failure can be ignored. This was a bug in PHP itself, which has already been fixed, it's just that the PHP 8.5 |
GaryJones
approved these changes
Aug 13, 2025
Member
Author
|
I've retriggered the PHP 8.5 tests now the Composer issue has been fixed. Tests pass, so all good. |
dingo-d
approved these changes
Aug 24, 2025
dingo-d
deleted the
feature/php-8.5-prevent-error-for-deprecated-type-casts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WP/EnqueuedResourceParameters: move parse error test to its own file
PHP 8.5 | WP/EnqueuedResourceParameters: prevent deprecation notice for non-standard casts
Four non-standard type casts are going to be deprecated in PHP 8.5.
When any of these type casts would be used in the parameter this sniff examines in the "code under scan" and the sniff would be run on PHP 8.5, the non-standard type cast would be executed via the
eval(), leading to a deprecation notice, which would stop the scan of the file.This commit works around this by always using the "standard" type cast syntax in the code which would be passed to
eval().Includes tests.