DB/PreparedSQLPlaceholders: fix false negative when checking quotes in dynamic generated placeholders #2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n dynamic generated placeholders The sniff was not accounting for fully qualified calls to `implode()` in the code that checks for quotes in dynamically generated placeholders.
GaryJones
approved these changes
Aug 8, 2025
dingo-d
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on preparing WPCS for the changes in PHPCS 4.0, more specifically the changes around namespace tokenization, I noticed that the
WordPress.DB.PreparedSQLPlaceholderssniff was not accounting for fully qualified calls toimplode()in the code that checks for quotes in dynamically generated placeholders. This PR fixes that. See the modified test for an example of a code that would cause a false negative.