Skip to content

GH Actions: Bump codecov/codecov-action from 4 to 5 #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dingo-d merged 1 commit into from
Nov 22, 2024
Merged

GH Actions: Bump codecov/codecov-action from 4 to 5 #2510

dingo-d merged 1 commit into from
Nov 22, 2024

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 18, 2024

Bumps codecov/codecov-action from 4 to 5.

Release notes

Sourced from codecov/codecov-action's releases.

v5.0.0

v5 Release

v5 of the Codecov GitHub Action will use the Codecov Wrapper to encapsulate the CLI. This will help ensure that the Action gets updates quicker.

Migration Guide

The v5 release also coincides with the opt-out feature for tokens for public repositories. In the Global Upload Token section of the settings page of an organization in codecov.io, you can set the ability for Codecov to receive a coverage reports from any source. This will allow contributors or other members of a repository to upload without needing access to the Codecov token. For more details see how to upload without a token.

[!WARNING]
The following arguments have been changed

  • file (this has been deprecated in favor of files)
  • plugin (this has been deprecated in favor of plugins)

The following arguments have been added:

  • binary
  • gcov_args
  • gcov_executable
  • gcov_ignore
  • gcov_include
  • report_type
  • skip_validation
  • swift_project

You can see their usage in the action.yml file.

What's Changed

... (truncated)

Changelog

Sourced from codecov/codecov-action's changelog.

4.0.0-beta.2

Fixes

  • #1085 not adding -n if empty to do-upload command

4.0.0-beta.1

v4 represents a move from the universal uploader to the Codecov CLI. Although this will unlock new features for our users, the CLI is not yet at feature parity with the universal uploader.

Breaking Changes

  • No current support for aarch64 and alpine architectures.
  • Tokenless uploading is unsuported
  • Various arguments to the Action have been removed

3.1.4

Fixes

  • #967 Fix typo in README.md
  • #971 fix: add back in working dir
  • #969 fix: CLI option names for uploader

Dependencies

  • #970 build(deps-dev): bump @​types/node from 18.15.12 to 18.16.3
  • #979 build(deps-dev): bump @​types/node from 20.1.0 to 20.1.2
  • #981 build(deps-dev): bump @​types/node from 20.1.2 to 20.1.4

3.1.3

Fixes

  • #960 fix: allow for aarch64 build

Dependencies

  • #957 build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0
  • #958 build(deps): bump openpgp from 5.7.0 to 5.8.0
  • #959 build(deps-dev): bump @​types/node from 18.15.10 to 18.15.12

3.1.2

Fixes

  • #718 Update README.md
  • #851 Remove unsupported path_to_write_report argument
  • #898 codeql-analysis.yml
  • #901 Update README to contain correct information - inputs and negate feature
  • #955 fix: add in all the extra arguments for uploader

Dependencies

  • #819 build(deps): bump openpgp from 5.4.0 to 5.5.0
  • #835 build(deps): bump node-fetch from 3.2.4 to 3.2.10
  • #840 build(deps): bump ossf/scorecard-action from 1.1.1 to 2.0.4
  • #841 build(deps): bump @​actions/core from 1.9.1 to 1.10.0
  • #843 build(deps): bump @​actions/github from 5.0.3 to 5.1.1
  • #869 build(deps): bump node-fetch from 3.2.10 to 3.3.0
  • #872 build(deps-dev): bump jest-junit from 13.2.0 to 15.0.0
  • #879 build(deps): bump decode-uri-component from 0.2.0 to 0.2.2

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@jrfnl
Copy link
Member

jrfnl commented Nov 18, 2024

I've reviewed the changelog and migration guide and AFAICS no changes should be needed to the action configuration.

However, the new version appears to be buggy (why, of course, it's CodeCov after all) and the Coverage status looks to never be reported back to PRs.

This is problematic as it makes CodeCov next to useless for preventing code not covered by tests from going in.

This has already been reported upstream and I would recommend NOT merging this PR until the upstream issue has been resolved and the fix is included in a new action runner release.

Ref: codecov/codecov-action#1662

@jrfnl jrfnl mentioned this pull request Nov 20, 2024
Closed
@jrfnl
Copy link
Member

jrfnl commented Nov 21, 2024

sigh Have restarted the builds quite a few times in the mean time at the request of the CodeCov team, but no luck, or rather, things just look to be getting worse. We are now also running into the following issue: codecov/codecov-action#1653

@GaryJones
Copy link
Member

GaryJones commented Nov 21, 2024

I solved that by referencing the token in a different way on Automattic/ad-code-manager.

@jrfnl
Copy link
Member

jrfnl commented Nov 21, 2024 •
edited
Loading

I solved that by referencing the token in a different way on Automattic/ad-code-manager.

I presume you mean by using with: token: ... ? We are using that in the Requests repo and it's still not working there.

I have in the mean time also reset the tokens in secrets, but still no luck.

jrfnl
jrfnl approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Twiddled around a bit more (and some more CodeCov 5.x releases later) and it now seems to work.

Note for the future: if at any point the CODECOV_TOKEN needs to be refreshed/set again, it needs to be done in two places: both in "normal" secrets and also in "Dependabot secrets".

@jrfnl jrfnl added this to the 3.2.0 milestone Nov 21, 2024
@dingo-d dingo-d merged commit 325a4d6 into develop Nov 22, 2024
46 checks passed
@dingo-d dingo-d deleted the dependabot/github_actions/codecov/codecov-action-5 branch November 22, 2024 07:13
lesterchan added a commit to lesterchan/WordPress-Coding-Standards that referenced this pull request Jun 8, 2025
@lesterchan
Merge remote-tracking branch 'upstream/develop' into develop
5003882 
* upstream/develop: (428 commits)
  Rulesets: update schema URL
  GH Actions: use the xmllint-validate action runner and enhance checks (WordPress#2522)
  AbstractFunctionParameterSniff: fix first class callables and function imports (WordPress#2518)
  DontExtractStandard.xml file creation (WordPress#2456)
  Add documentation for WordPress.NamingConventions.ValidVariableName (WordPress#2457)
  Remove unused variables from a few sniffs (WordPress#2514)
  I18nTextDomainFixer: remove unnecessary variable initialization (WordPress#2513)
  GH Actions: Bump codecov/codecov-action from 4 to 5 (WordPress#2510)
  GH Actions: PHP 8.4 has been released
  CS/QA: remove redundant condition
  GH Actions: use explicit PHPStan major
  Various sniffs: simplify skipping the rest of the file
  GH Actions: always quote variables
  Release checklist: add new action item
  AbstractClassRestrictionsSniff: fix insufficient defensive coding (WordPress#2500)
  ✨ New WordPress.WP.GetMetaSingle sniff (WordPress#2465)
  Fix typo in AbstractFunctionRestrictionsSniff::is_targetted_token() DocBlock (WordPress#2477)
  Fix typos (WordPress#2472)
  Documentation: capitalization consistency fixes (WordPress#2469)
  [Documentation]: WordPress.DB.PreparedSQL (WordPress#2454)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrfnl jrfnl jrfnl approved these changes

@dingo-d dingo-d dingo-d approved these changes

Assignees

No one assigned

Labels

Type: Chores/Cleanup

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jrfnl @GaryJones @dingo-d