Security/EscapeOutputSniff: More modular error codes #2378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits certain cases out of `OutputNotEscaped` to allow for ignoring certain cases that are looking at error strings at time of generation (where they may eventually be used in both HTML and non-HTML contexts) rather than at time of output. * `ExceptionNotEscaped` for unescaped strings in throws (cf. WordPress#2374). * `ErrorNotEscaped` for unescaped strings in `trigger_error` (cf. WordPress#1864).
anomiex
commented
Sep 3, 2023
1 task
jrfnl
reviewed
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits certain cases out of
OutputNotEscapedto allow for ignoring certain cases that are looking at error strings at time of generation (where they may eventually be used in both HTML and non-HTML contexts) rather than at time of output.ExceptionNotEscapedfor unescaped strings in throws (cf. WordPress.Security.EscapeOutput encourages bad practice wrt exceptions #2374).ErrorNotEscapedfor unescaped strings intrigger_error(cf. trigger_error is counted as an output function for escaping purposes #1864).