GH Actions/update-website: stop submitting test PRs on workflow update #999
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/ghactions-no-longer-open-test-prs
branch
2 times, most recently
from
eae8692 to
0e11871
Compare
Member
Author
|
Sorry for the commit noise, hoping things are finally correct. |
schlessera
approved these changes
Dec 12, 2025
Currently, the `update-website` workflow doesn't deploy the website straight away. Instead it opens a PR with the files which will be changed to allow for review of the website changes before deploying the updated website (by merging the PR). To that end, the workflow is run: * Whenever a tag is created. * When a pull request changes any of the files directly involved in updating the website. * When manually requested. What with the frequent Dependabot updates, this has become quite noisy for the "pull request which changes the workflow" trigger. To that end, this commit blocks the opening of the PR when the workflow/doc building files are changed, while still running the rest of the workflow to verify that the workflow wasn't broken by the changes. It also introduces a new step to create the branch holding the changes in the local environment. This was previously done via the "create PR" step, which will now be skipped, while we still need the branch for verifying Ruby can build the GH Pages site. As the branch should now be checked-out already before we even get to the part of the workflow verifying the site can be build via GH Pages, we can also remove the separate `actions/checkout` step.
jrfnl
force-pushed
the
feature/ghactions-no-longer-open-test-prs
branch
from
0e11871 to
c1d93a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Detailed Description
Currently, the
update-websiteworkflow doesn't deploy the website straight away. Instead it opens a PR with the files which will be changed to allow for review of the website changes before deploying the updated website (by merging the PR).To that end, the workflow is run:
What with the frequent Dependabot updates, this has become quite noisy for the "pull request which changes the workflow" trigger.
To that end, this commit blocks the opening of the PR when the workflow/doc building files are changed, while still running the rest of the workflow to verify that the workflow wasn't broken by the changes.
It also introduces a new step to create the branch holding the changes in the local environment.
This was previously done via the "create PR" step, which will now be skipped, while we still need the branch for verifying Ruby can build the GH Pages site.
As the branch should now be checked-out already before we even get to the part of the workflow verifying the site can be build via GH Pages, we can also remove the separate
actions/checkoutstep.