Replace FILTER_SANITIZE_STRING into better data sanitisation#3185
Merged
dd32 merged 4 commits intoWordPress:trunkfrom Mar 19, 2026
Merged
Replace FILTER_SANITIZE_STRING into better data sanitisation#3185dd32 merged 4 commits intoWordPress:trunkfrom
dd32 merged 4 commits intoWordPress:trunkfrom
Conversation
WordPress adds slashes to superglobals - wp_unslash() must be called before sanitize_text_field/sanitize_textarea_field/sanitize_email to avoid leaving stray backslashes in user input. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…onstant # Conflicts: # wp-content/plugins/wporg-learn/inc/form.php # wp-content/plugins/wporg-learn/inc/post-meta.php
Member
|
I commited some changed in #3394, I'm going to merge your PR over the top of it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace FILTER_SANITIZE_STRING with WordPress Sanitization Functions
Changes Made
Replaced all instances of
FILTER_SANITIZE_STRINGwith WordPress's built-in sanitization functions:sanitize_text_field()for single-line text inputssanitize_textarea_field()for multi-line text inputssanitize_email()for email fieldsUpdated form submission handling in
inc/form.php:filter_input_array()with direct$_POSThandlingUpdated admin filters in
inc/admin.php:filter_input()calls withsanitize_text_field()Updated post meta handling in
inc/post-meta.php:FILTER_SANITIZE_STRINGsanitize_text_field()directlyWhy This Change?
FILTER_SANITIZE_STRINGis deprecated in PHP 8.1Testing
The changes maintain the same functionality while improving security and future compatibility. All form submissions, admin filters, and post meta handling should work as before but with better sanitization.
!! Since we don't have testunit, this still needs a manual testing. Make sure that it has been tested thoroughly before merging!
Related Issues
Issue reported: #2525