Skip to content

Add single contribute page #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
outdoor2kode merged 12 commits into from
Jun 20, 2024
Merged

Add single contribute page #2542

outdoor2kode merged 12 commits into from
Jun 20, 2024

Conversation

@outdoor2kode
Copy link
Contributor

@outdoor2kode outdoor2kode commented Jun 18, 2024

Closes #2395

Using the sandbox to test is more convenient, as videos cannot be embedded locally.

Screenshot

Screenshot 2024-06-18 at 11 40 11
image
image
image

@outdoor2kode outdoor2kode added the [Component] Learn Theme Website development issues related to the Learn theme. label Jun 18, 2024
@outdoor2kode outdoor2kode added this to the Learning Pathways launch milestone Jun 18, 2024
@outdoor2kode outdoor2kode requested a review from adamwoodnz June 18, 2024 02:43
@outdoor2kode outdoor2kode self-assigned this Jun 18, 2024
adamwoodnz
adamwoodnz requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few comments inline.

I noticed the layout isn't quite working on smaller screens:

Tablet Mobile
localhost_8888_contribute_(iPad) localhost_8888_contribute_(Samsung Galaxy S20 Ultra)

If you copy the wrappers from page.html I think it should just work.

@outdoor2kode
Copy link
Contributor Author

outdoor2kode commented Jun 18, 2024

Thanks for the review! c0b38b8 fixed the layout problem.

@outdoor2kode outdoor2kode requested a review from adamwoodnz June 18, 2024 19:43
adamwoodnz
adamwoodnz requested changes Jun 19, 2024
View reviewed changes
@outdoor2kode outdoor2kode requested a review from adamwoodnz June 19, 2024 15:28
adamwoodnz
adamwoodnz reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all the links and layout looks good now. Just need to update the title tag and we can probably merge. If we need to remove sections we can follow up. I have pinged for input though.

@kaitohm
Copy link
Contributor

kaitohm commented Jun 20, 2024

Thanks for the ping. We can remove sections for both Tutorials and Lesson Plans.

  • Facilitate and Online Workshop
  • Update and contribute to courses
  • Join the Training Team

I have a feeling we'd want to update the text and videos on this page entirely, but we can open a new issue for that later.

@outdoor2kode outdoor2kode force-pushed the 2395-add-single-contribute-page branch from 033b1ee to 5535c4f Compare June 20, 2024 12:56
@outdoor2kode outdoor2kode requested a review from adamwoodnz June 20, 2024 13:36
@outdoor2kode outdoor2kode force-pushed the 2395-add-single-contribute-page branch from be50377 to 1bced71 Compare June 20, 2024 13:45
@outdoor2kode outdoor2kode force-pushed the 2395-add-single-contribute-page branch from 1bced71 to 90d0408 Compare June 20, 2024 13:46
@outdoor2kode
Copy link
Contributor Author

outdoor2kode commented Jun 20, 2024

Checked all the links and layout looks good now. Just need to update the title tag and we can probably merge. If we need to remove sections we can follow up. I have pinged for input though.

Thanks for the thorough review! 5535c4f
I've also cleaned up the styles being used on markup and aligned padding top/bottom with the design for breadcrumbs in the following commits.

Thanks for the ping. We can remove sections for both Tutorials and Lesson Plans.

Removed in 470f6fa.

adamwoodnz
adamwoodnz approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@outdoor2kode outdoor2kode merged commit 67b491b into trunk Jun 20, 2024
@outdoor2kode outdoor2kode deleted the 2395-add-single-contribute-page branch June 20, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwoodnz adamwoodnz adamwoodnz approved these changes

Assignees

@outdoor2kode outdoor2kode

Labels

[Component] Learn Theme Website development issues related to the Learn theme.

Projects

WordPress.org
Status: ✅ Done

Milestone

Learning Pathways launch

Development

Successfully merging this pull request may close these issues.

Contribute page

4 participants

@outdoor2kode @kaitohm @adamwoodnz