Skip to content

Conversation

@adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented May 22, 2024

Adds all the sections to the front page, some parts still have dummy content.

Includes:

  • Query Loop block variation for the Courses grid, to add filtering for Featured Courses
  • Modifications to queries for Courses to include the Featured Course meta query
  • Custom block for Upcoming Online Workshops
  • Course card meta data (Duration, Lesson Count, Status)
  • Lesson card meta data (Duration, Experience Level)

Not included, to limit the size as PR is already big:

  • Subscription form
  • Online Workshop card featured image (waiting for support in the Meeting plugin)
  • Fallback image in cards when there is no featured image

See #2394

Screenshots

Frontend

Desktop Tablet Mobile
localhost_8888_(Desktop) localhost_8888_(iPad) (3) localhost_8888_(Samsung Galaxy S20 Ultra) (3)

Admin

Screenshot 2024-05-27 at 10 20 45 PM

Testing notes

You'll need content configured for each section. Easiest to look at production and copy some.
For Online Workshops I had to manipulate data in the wporg-events table directly, as entering new Meetings in the admin didn't seem to create items in the table. Not sure how this works in prod.

@adamwoodnz adamwoodnz changed the base branch from trunk to add/2443-learning-pathways-block May 22, 2024 10:44
@adamwoodnz adamwoodnz self-assigned this May 22, 2024
@adamwoodnz adamwoodnz added this to the Learning Pathways launch milestone May 22, 2024
@adamwoodnz adamwoodnz added the [Component] Learn Plugin Website development issues related to the Learn plugin. label May 22, 2024
Base automatically changed from add/2443-learning-pathways-block to trunk May 22, 2024 22:24
@adamwoodnz adamwoodnz force-pushed the update/2394-front-page branch 7 times, most recently from d12ba28 to 1b7c00e Compare May 24, 2024 01:39
@adamwoodnz adamwoodnz marked this pull request as ready for review May 24, 2024 04:36
@adamwoodnz adamwoodnz requested review from a team, StevenDufresne, outdoor2kode and ryelle May 24, 2024 04:36
<!-- wp:wporg-learn/upcoming-online-workshops {"style":{"spacing":{"margin":{"top":"var:preset|spacing|40","bottom":"var:preset|spacing|50"}}}} /-->

<!-- wp:paragraph {"fontSize":"huge","fontFamily":"eb-garamond"} -->
<p class="has-eb-garamond-font-family has-huge-font-size">[TBD. Paragraph about inviting users to join the Training team to contribute with content creation]</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally not translated while copy is pending

'<!-- wp:wporg/link-wrapper -->
<a class="wp-block-wporg-link-wrapper" href="%1$s">
Copy link
Contributor Author

@adamwoodnz adamwoodnz May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to change to a more complex layout like the other sections when the featured image is supported in the Meeting plugin. For now it uses a simple card link wrapper like we use on other home pages, like Developer Resources.

@adamwoodnz adamwoodnz force-pushed the update/2394-front-page branch from 1bbc499 to f10fb58 Compare May 24, 2024 05:07
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamwoodnz adamwoodnz added the [Component] Learn Theme Website development issues related to the Learn theme. label May 24, 2024
@adamwoodnz adamwoodnz changed the title Complete front page template Complete front page template layout May 24, 2024
@adamwoodnz adamwoodnz force-pushed the update/2394-front-page branch from f10fb58 to 666846a Compare May 27, 2024 01:16
@jasmussen
Copy link

Looks good at a glance. I'll defer to @fcoveram on details, but a few quick thoughts from my end:

  • Maybe show 2 columns on the tablet break?
  • We probably need a taller margin below each stack of cards.

The margin on mobile between the intro cards and "Featured courses" is a bit tight:

Screenshot 2024-05-27 at 08 59 17

@fcoveram
Copy link

Agree with @jasmussen's points, and I would include showing each Learning Pathway banner in full width on Tablet

@adamwoodnz adamwoodnz force-pushed the update/2394-front-page branch from 3fdaa7a to 53b937e Compare May 27, 2024 23:19
@adamwoodnz adamwoodnz force-pushed the update/2394-front-page branch from 53b937e to 3056ba0 Compare May 27, 2024 23:22
@adamwoodnz adamwoodnz force-pushed the update/2394-front-page branch from bb9fbf7 to d2ef935 Compare May 28, 2024 03:57
@adamwoodnz adamwoodnz added the Dev label May 28, 2024
@adamwoodnz
Copy link
Contributor Author

Columns and vertical spacing adjusted now @WordPress/meta-design

Screenshots

Desktop Tablet Mobile
localhost_8888_(Desktop) (3) localhost_8888_(iPad) (4) localhost_8888_(Samsung Galaxy S20 Ultra) (4)

@adamwoodnz adamwoodnz merged commit 56fc00f into trunk May 29, 2024
@adamwoodnz adamwoodnz deleted the update/2394-front-page branch May 29, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Component] Learn Plugin Website development issues related to the Learn plugin. [Component] Learn Theme Website development issues related to the Learn theme. Dev

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants