-
Notifications
You must be signed in to change notification settings - Fork 122
Complete front page template layout #2457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d12ba28 to
1b7c00e
Compare
| <!-- wp:wporg-learn/upcoming-online-workshops {"style":{"spacing":{"margin":{"top":"var:preset|spacing|40","bottom":"var:preset|spacing|50"}}}} /--> | ||
|
|
||
| <!-- wp:paragraph {"fontSize":"huge","fontFamily":"eb-garamond"} --> | ||
| <p class="has-eb-garamond-font-family has-huge-font-size">[TBD. Paragraph about inviting users to join the Training team to contribute with content creation]</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally not translated while copy is pending
| '<!-- wp:wporg/link-wrapper --> | ||
| <a class="wp-block-wporg-link-wrapper" href="%1$s"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to change to a more complex layout like the other sections when the featured image is supported in the Meeting plugin. For now it uses a simple card link wrapper like we use on other home pages, like Developer Resources.
1bbc499 to
f10fb58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from https://github.com/WordPress/Learn/blob/trunk/wp-content/plugins/wporg-learn/js/event.js and modified to return only the time
Enables filtering on featured course post meta
f10fb58 to
666846a
Compare
|
Looks good at a glance. I'll defer to @fcoveram on details, but a few quick thoughts from my end:
The margin on mobile between the intro cards and "Featured courses" is a bit tight: |
|
Agree with @jasmussen's points, and I would include showing each Learning Pathway banner in full width on Tablet |
3fdaa7a to
53b937e
Compare
53b937e to
3056ba0
Compare
wp-content/themes/pub/wporg-learn-2024/src/upcoming-online-workshops/block.php
Outdated
Show resolved
Hide resolved
bb9fbf7 to
d2ef935
Compare




Adds all the sections to the front page, some parts still have dummy content.
Includes:
Not included, to limit the size as PR is already big:
See #2394
Screenshots
Frontend
Admin
Testing notes
You'll need content configured for each section. Easiest to look at production and copy some.
For Online Workshops I had to manipulate data in the
wporg-eventstable directly, as entering new Meetings in the admin didn't seem to create items in the table. Not sure how this works in prod.