Drop prebuilds of Node.js v21 and Electron v25#1191
Merged
JoshuaWise merged 4 commits intoWiseLibs:masterfrom May 30, 2024
Merged
Drop prebuilds of Node.js v21 and Electron v25#1191JoshuaWise merged 4 commits intoWiseLibs:masterfrom
JoshuaWise merged 4 commits intoWiseLibs:masterfrom
Conversation
mceachen
changed the title
JoshuaWise
approved these changes
May 30, 2024
ArGeoph
pushed a commit
to ArGeoph/better-sqlite3
that referenced
this pull request
Mar 21, 2025
* Drop unsupported versions of node and electron * Drop Node.js v21 prebuilds * Also drop electron v25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js v21 goes EOL day after tomorrow: Electron v25 has been EOL since last December. The next release needs to be major.
Note that this does a bit of cleanup, and adds
fail-fast: falseto let as many prebuilds happen as possible. See #1186 and #1192