Prevent users from saving emojis as their display name#1325
Merged
erinz2020 merged 2 commits intoWildMeOrg:mainfrom Dec 12, 2025
Merged
Prevent users from saving emojis as their display name#1325erinz2020 merged 2 commits intoWildMeOrg:mainfrom
erinz2020 merged 2 commits intoWildMeOrg:mainfrom
Conversation
erinz2020
approved these changes
Dec 10, 2025
Contributor
erinz2020
left a comment
erinz2020
left a comment
There was a problem hiding this comment.
LGTM! thank you for working on the emoji validation! the regex covers most common cases well.
suggestion: consider using \p{Emoji} with a fallback for better coverage and maintainability.
benefits:
simpler and more maintainable
catches edge cases like ⭐
future-proof for new emojis
but if you prefer to keep the current implementation for maximum browser compatibility, that's fine too. Up to you!
I'll approve the PR.
Contributor
Author
|
I've implemented your suggestion and updated the PR to use \p{Emoji}. Thanks for the tip! |
Contributor
perfect! i'll go ahead and merge it, so it goes to 10.9. thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emoji Validation for Full Name Field
Added client-side validation to prevent users from entering emojis in the Full Name field on the profile page (
/myAccount.jsp). This ensures the field remains searchable and readable across the platform.Changes Made
containsEmoji()- Detects emojis using comprehensive Unicode regex patternssendButtonClicked()- Now validates Full Name for emojis before form submissionFiles Modified
myAccount.jsp- Added emoji validation logic in JavaScript sectionPR fixes #1324
Before you Submit!