Skip to content

[blocks-in-inline] Don't wrap sequences of blocks in anonymous block#55250

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
anttijk:blocks-in-inline-no-anon
Dec 12, 2025
Merged

[blocks-in-inline] Don't wrap sequences of blocks in anonymous block#55250
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
anttijk:blocks-in-inline-no-anon

Conversation

@anttijk
Copy link
Copy Markdown
Contributor

@anttijk anttijk commented Dec 11, 2025 •
edited by webkit-early-warning-system
Loading

95b8f1effe20dd5720249113ce534e3d01f7d9b8

[blocks-in-inline] Don't wrap sequences of blocks in anonymous block
https://bugs.webkit.org/show_bug.cgi?id=303999
rdar://166306432

Reviewed by NOBODY (OOPS!).

We already don't wrap single blocks. Remove remaining anonymous block wrapping.

* LayoutTests/editing/selection/hit-test-continuation-margin-expected.html:
* LayoutTests/editing/selection/hit-test-continuation-margin.html:

This is a progression, our selection behavior now matches with or without the span.
Change the ref to be the spanless case.

* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::updateAfterDescendants):
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::RenderTreeBuilder::Inline::updateAfterDescendants): Deleted.
(WebCore::RenderTreeBuilder::Inline::wrapRunsOfBlocksInAnonymousBlock): Deleted.
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.h:

95b8f1e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt   🧪 api-mac-debug   🛠 wpe-cairo-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1   🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk self-assigned this Dec 11, 2025
@anttijk anttijk added the Layout and Rendering For bugs with layout and rendering of Web pages. label Dec 11, 2025
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Dec 11, 2025 •
edited
Loading

EWS run on previous version of this PR (hash b74e582)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ❌ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ❌ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ❌ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk added the no-failure-limits Disable layout test failure limits on a pull-request label Dec 11, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 11, 2025
@anttijk anttijk removed the merging-blocked Applied to prevent a change from being merged label Dec 12, 2025
@anttijk anttijk force-pushed the blocks-in-inline-no-anon branch from b74e582 to 33c10f2 Compare December 12, 2025 10:53
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Dec 12, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 33c10f2)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ⏳ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
⏳ 🧪 ios-wk2-wpt   🧪 api-mac-debug   🛠 wpe-cairo-libwebrtc
⏳ 🧪 api-ios   🧪 mac-wk1   🛠 gtk
✅ 🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-wk2-stress ⏳ 🛠 playstation
✅ 🛠 tv ⏳ 🧪 mac-intel-wk2 ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim   🛠 mac-safer-cpp ⏳ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk force-pushed the blocks-in-inline-no-anon branch from 33c10f2 to ce2e203 Compare December 12, 2025 10:56
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Dec 12, 2025 •
edited
Loading

EWS run on previous version of this PR (hash ce2e203)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
⏳ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ⏳ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk removed the no-failure-limits Disable layout test failure limits on a pull-request label Dec 12, 2025
@anttijk anttijk marked this pull request as ready for review December 12, 2025 10:57
@anttijk anttijk requested a review from rniwa as a code owner December 12, 2025 10:57
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 12, 2025
@anttijk anttijk removed the merging-blocked Applied to prevent a change from being merged label Dec 12, 2025
@anttijk anttijk force-pushed the blocks-in-inline-no-anon branch from ce2e203 to 95b8f1e Compare December 12, 2025 12:58
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Dec 12, 2025 •
edited
Loading

EWS run on current version of this PR (hash 95b8f1e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt   🧪 api-mac-debug   🛠 wpe-cairo-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1   🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Dec 12, 2025
@anttijk
[blocks-in-inline] Don't wrap sequences of blocks in anonymous block
506bc07 
https://bugs.webkit.org/show_bug.cgi?id=303999
rdar://166306432

Reviewed by Alan Baradlay.

We already don't wrap single blocks. Remove remaining anonymous block wrapping.

* LayoutTests/editing/selection/hit-test-continuation-margin-expected.html:
* LayoutTests/editing/selection/hit-test-continuation-margin.html:

This is a progression, our selection behavior now matches with or without the span.
Change the ref to be the spanless case.

* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::updateAfterDescendants):
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::RenderTreeBuilder::Inline::updateAfterDescendants): Deleted.
(WebCore::RenderTreeBuilder::Inline::wrapRunsOfBlocksInAnonymousBlock): Deleted.
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.h:

Canonical link: https://commits.webkit.org/304357@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Dec 12, 2025

Committed 304357@main (506bc07): https://commits.webkit.org/304357@main

Reviewed commits have been landed. Closing PR #55250 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 506bc07 into WebKit:main Dec 12, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 12, 2025
@Loirooriol Loirooriol mentioned this pull request Jan 2, 2026
Closed
@Loirooriol Loirooriol mentioned this pull request Mar 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanbaradlay alanbaradlay alanbaradlay approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

Assignees

@anttijk anttijk

Labels

Layout and Rendering For bugs with layout and rendering of Web pages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anttijk @webkit-early-warning-system @webkit-commit-queue @alanbaradlay @webkit-ews-buildbot