Set empty string for reflection of IDREF attributes#4977
Merged
webkit-early-warning-system merged 1 commit intoWebKit:mainfrom Oct 7, 2022
Merged
Set empty string for reflection of IDREF attributes#4977webkit-early-warning-system merged 1 commit intoWebKit:mainfrom
webkit-early-warning-system merged 1 commit intoWebKit:mainfrom
Conversation
mrego
added
Accessibility
Collaborator
|
EWS run on previous version of this PR (hash d142ee4) Details
|
3 tasks
webkit-ews-buildbot
added
the
merging-blocked
mrego
force-pushed
the
idref-reflection-empty-string
branch
from
d142ee4 to
4454086
Compare
Collaborator
|
EWS run on current version of this PR (hash 4454086) Details |
https://bugs.webkit.org/show_bug.cgi?id=245299 This implements the agreement on the following HTML issue: whatwg/html#8306 HTML PR is available at: whatwg/html#8352 It just always set the content attribute to the empty string in Element::setElementAttribute() and Element::setElementsArrayAttribute(). The tests are updated accordingly to the new behavior. Reviewed by Ryosuke Niwa. * LayoutTests/accessibility/ARIA-reflection-expected.txt: * LayoutTests/accessibility/ARIA-reflection.html: * LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html: * LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-element-reflection.html: * Source/WebCore/dom/Element.cpp: (WebCore::Element::setElementAttribute): (WebCore::Element::setElementsArrayAttribute): Canonical link: https://commits.webkit.org/255267@main
webkit-early-warning-system
force-pushed
the
idref-reflection-empty-string
branch
from
4454086 to
05f0430
Compare
Collaborator
|
Committed 255267@main (05f0430): https://commits.webkit.org/255267@main Reviewed commits have been landed. Closing PR #4977 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
05f0430
4454086