Skip to content

Support InputEvent.isComposing #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-early-warning-system merged 1 commit into from
Sep 3, 2022
Merged

Support InputEvent.isComposing #3990

webkit-early-warning-system merged 1 commit into from
Sep 3, 2022

Conversation

@rniwa
Copy link
Member

@rniwa rniwa commented Sep 3, 2022 •
edited by webkit-early-warning-system
Loading

1aeb332

Support InputEvent.isComposing
https://bugs.webkit.org/show_bug.cgi?id=170414

Reviewed by Wenson Hsieh.

Add isComposing boolean to InputEvent and InputEventInit.

* LayoutTests/fast/events/input-event-insert-replacement-expected.txt:
* LayoutTests/fast/events/input-event-insert-replacement.html:
* LayoutTests/fast/events/input-events-drag-and-drop-expected.txt:
* LayoutTests/fast/events/input-events-drag-and-drop.html:
* LayoutTests/fast/events/input-events-fired-when-typing-expected.txt:
* LayoutTests/fast/events/input-events-fired-when-typing.html:
* LayoutTests/fast/events/input-events-forecolor-data-expected.txt:
* LayoutTests/fast/events/input-events-forecolor-data.html:
* LayoutTests/fast/events/input-events-ime-composition-expected.txt:
* LayoutTests/fast/events/input-events-ime-composition.html:
* LayoutTests/fast/events/input-events-ime-recomposition-expected.txt:
* LayoutTests/fast/events/input-events-ime-recomposition.html:
* LayoutTests/fast/events/input-events-insert-by-drop.html:
* LayoutTests/fast/events/input-events-typing-data-expected.txt:
* LayoutTests/fast/events/input-events-typing-data.html:
* LayoutTests/imported/w3c/web-platform-tests/uievents/constructors/inputevent-constructor-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/uievents/idlharness.window-expected.txt:

* Source/WebCore/dom/InputEvent.cpp:
(WebCore::InputEvent::create):
(WebCore::InputEvent::InputEvent):
* Source/WebCore/dom/InputEvent.h:
* Source/WebCore/dom/InputEvent.idl:
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::isInputMethodComposing const): Added.
* Source/WebCore/editing/CompositeEditCommand.h:
* Source/WebCore/editing/EditCommand.cpp:
(WebCore::isInputMethodComposingForEditingAction): Added.
* Source/WebCore/editing/EditCommand.h:
* Source/WebCore/editing/Editor.cpp:
(WebCore::dispatchBeforeInputEvent):
(WebCore::dispatchInputEvent):
(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::dispatchBeforeInputEvents):
(WebCore::dispatchInputEvents):
(WebCore::Editor::willApplyEditing):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::willUnapplyEditing const):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::willReapplyEditing const):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::setBaseWritingDirection):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::isInputMethodComposing const): Added.
* Source/WebCore/editing/TypingCommand.h:

Canonical link: https://commits.webkit.org/254131@main

2fd49c4

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@rniwa rniwa requested a review from cdumez as a code owner September 3, 2022 10:22
@rniwa rniwa self-assigned this Sep 3, 2022
@rniwa rniwa added HTML Editing For bugs in HTML editing support (including designMode and contentEditable). Safari Technology Preview labels Sep 3, 2022
@rniwa rniwa requested a review from whsieh September 3, 2022 10:22
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 3, 2022 •
edited
Loading

EWS run on previous version of this PR (hash 288338a)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style   🛠 ios   🛠 mac ❌ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-debug ❌ 🛠 gtk ❌ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
❌ 🧪 api-ios   🧪 api-mac ❌ 🧪 api-gtk
❌ 🛠 tv   🧪 mac-wk1
❌ 🛠 tv-sim   🧪 mac-wk2
❌ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
❌ 🛠 watch-sim   🧪 mac-wk2-stress

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 3, 2022
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Sep 3, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 3, 2022 •
edited
Loading

2fd49c4

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

whsieh
whsieh approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@whsieh whsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 3, 2022
@rniwa
Support InputEvent.isComposing
1aeb332 
https://bugs.webkit.org/show_bug.cgi?id=170414

Reviewed by Wenson Hsieh.

Add isComposing boolean to InputEvent and InputEventInit.

* LayoutTests/fast/events/input-event-insert-replacement-expected.txt:
* LayoutTests/fast/events/input-event-insert-replacement.html:
* LayoutTests/fast/events/input-events-drag-and-drop-expected.txt:
* LayoutTests/fast/events/input-events-drag-and-drop.html:
* LayoutTests/fast/events/input-events-fired-when-typing-expected.txt:
* LayoutTests/fast/events/input-events-fired-when-typing.html:
* LayoutTests/fast/events/input-events-forecolor-data-expected.txt:
* LayoutTests/fast/events/input-events-forecolor-data.html:
* LayoutTests/fast/events/input-events-ime-composition-expected.txt:
* LayoutTests/fast/events/input-events-ime-composition.html:
* LayoutTests/fast/events/input-events-ime-recomposition-expected.txt:
* LayoutTests/fast/events/input-events-ime-recomposition.html:
* LayoutTests/fast/events/input-events-insert-by-drop.html:
* LayoutTests/fast/events/input-events-typing-data-expected.txt:
* LayoutTests/fast/events/input-events-typing-data.html:
* LayoutTests/imported/w3c/web-platform-tests/uievents/constructors/inputevent-constructor-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/uievents/idlharness.window-expected.txt:

* Source/WebCore/dom/InputEvent.cpp:
(WebCore::InputEvent::create):
(WebCore::InputEvent::InputEvent):
* Source/WebCore/dom/InputEvent.h:
* Source/WebCore/dom/InputEvent.idl:
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::isInputMethodComposing const): Added.
* Source/WebCore/editing/CompositeEditCommand.h:
* Source/WebCore/editing/EditCommand.cpp:
(WebCore::isInputMethodComposingForEditingAction): Added.
* Source/WebCore/editing/EditCommand.h:
* Source/WebCore/editing/Editor.cpp:
(WebCore::dispatchBeforeInputEvent):
(WebCore::dispatchInputEvent):
(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::dispatchBeforeInputEvents):
(WebCore::dispatchInputEvents):
(WebCore::Editor::willApplyEditing):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::willUnapplyEditing const):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::willReapplyEditing const):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::setBaseWritingDirection):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::isInputMethodComposing const): Added.
* Source/WebCore/editing/TypingCommand.h:

Canonical link: https://commits.webkit.org/254131@main
@webkit-early-warning-system webkit-early-warning-system merged commit 1aeb332 into WebKit:main Sep 3, 2022
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Sep 3, 2022

Committed 254131@main (1aeb332): https://commits.webkit.org/254131@main

Reviewed commits have been landed. Closing PR #3990 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 3, 2022
@rniwa rniwa deleted the fix170414 branch September 3, 2022 17:54
@knopp knopp mentioned this pull request Sep 3, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whsieh whsieh whsieh approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@rniwa rniwa

Labels

HTML Editing For bugs in HTML editing support (including designMode and contentEditable).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rniwa @webkit-early-warning-system @webkit-commit-queue @whsieh @webkit-ews-buildbot