Skip to content

[css-anchor-position-1] Re-import css/css-anchor-position WPT#35212

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Scony:281290-css-anchoring-wpt-reimport
Oct 16, 2024
Merged

[css-anchor-position-1] Re-import css/css-anchor-position WPT#35212
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Scony:281290-css-anchoring-wpt-reimport

Conversation

@Scony
Copy link
Copy Markdown
Contributor

@Scony Scony commented Oct 15, 2024 •
edited by webkit-early-warning-system
Loading

8f748e5

[css-anchor-position-1] Re-import css/css-anchor-position WPT
https://bugs.webkit.org/show_bug.cgi?id=281290

Reviewed by Tim Nguyen.

This change re-imports css/css-anchor-position WPT test cases.
Upstream commit: web-platform-tests/wpt@671df7f

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-invalid-fallback-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-invalid-fallback.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-parse-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-parse-invalid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/popover-implicit-anchor.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/popover-implicit-anchor.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-004-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-004.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-target-with-children-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-target-with-children-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-target-with-children.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/w3c-import.log:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-anchor-position/popover-implicit-anchor.tentative-expected.txt: Added.

Canonical link: https://commits.webkit.org/285249@main

dd63ccd

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Scony Scony force-pushed the 281290-css-anchoring-wpt-reimport branch from a623a79 to ae79bea Compare October 15, 2024 10:42
@Scony Scony self-assigned this Oct 15, 2024
@Scony Scony added the CSS Cascading Style Sheets implementation label Oct 15, 2024
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Oct 15, 2024 •
edited
Loading

EWS run on previous version of this PR (hash ae79bea)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 15, 2024
@Scony Scony removed the merging-blocked Applied to prevent a change from being merged label Oct 15, 2024
@Scony Scony force-pushed the 281290-css-anchoring-wpt-reimport branch from ae79bea to 3703b9a Compare October 15, 2024 14:13
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Oct 15, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 3703b9a)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Scony Scony requested review from anttijk and tuankiet65 October 15, 2024 14:14
nt1m
nt1m approved these changes Oct 15, 2024
View reviewed changes
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 15, 2024
@Scony Scony removed the merging-blocked Applied to prevent a change from being merged label Oct 15, 2024
@Scony Scony force-pushed the 281290-css-anchoring-wpt-reimport branch from 3703b9a to dd63ccd Compare October 15, 2024 20:16
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Oct 15, 2024 •
edited
Loading

EWS run on current version of this PR (hash dd63ccd)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@tuankiet65
Copy link
Copy Markdown
Member

tuankiet65 commented Oct 15, 2024

Looks good to me!

@Scony Scony added the merge-queue Applied to send a pull request to merge-queue label Oct 16, 2024
@Scony
[css-anchor-position-1] Re-import css/css-anchor-position WPT
8f748e5 
https://bugs.webkit.org/show_bug.cgi?id=281290

Reviewed by Tim Nguyen.

This change re-imports css/css-anchor-position WPT test cases.
Upstream commit: web-platform-tests/wpt@671df7f

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-invalid-fallback-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-invalid-fallback.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-parse-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-parse-invalid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/popover-implicit-anchor.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/popover-implicit-anchor.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-004-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-004.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-target-with-children-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-target-with-children-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-anchor-target-with-children.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/w3c-import.log:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-anchor-position/popover-implicit-anchor.tentative-expected.txt: Added.

Canonical link: https://commits.webkit.org/285249@main
@webkit-commit-queue webkit-commit-queue force-pushed the 281290-css-anchoring-wpt-reimport branch from dd63ccd to 8f748e5 Compare October 16, 2024 08:18
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Oct 16, 2024

Committed 285249@main (8f748e5): https://commits.webkit.org/285249@main

Reviewed commits have been landed. Closing PR #35212 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8f748e5 into WebKit:main Oct 16, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nt1m nt1m nt1m approved these changes

@anttijk anttijk Awaiting requested review from anttijk

@tuankiet65 tuankiet65 Awaiting requested review from tuankiet65

Assignees

@Scony Scony

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Scony @webkit-early-warning-system @tuankiet65 @webkit-commit-queue @nt1m @webkit-ews-buildbot