[macOS] Enable Navigator.standalone on macOS

Luming Yin · nt1m · commit 371895349410 · 2023-06-08T17:40:48.000-07:00
https://bugs.webkit.org/show_bug.cgi?id=257776 rdar://110362364 Reviewed by Tim Nguyen. Enable Navigator.standalone for all Cocoa platforms, which including macOS and iOS. * LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Rebaseline layout tests to reflect the availability of navigator.standalone. * Source/WTF/wtf/PlatformEnableCocoa.h: Same as above. * Source/WebCore/page/Navigator.cpp: * Source/WebCore/page/Navigator.h: Change compile-time flag to check for ENABLE(NAVIGATOR_STANDALONE) instead of PLATFORM(IOS_FAMILY). Canonical link: https://commits.webkit.org/265004@main
diff --git a/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt b/LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt
@@ -22,6 +22,7 @@ navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
 navigator.requestMediaKeySystemAccess() is OK
+navigator.standalone is OK
 navigator.storage is OK
 navigator.userActivation is OK
 navigator.userAgent is OK
@@ -51,6 +52,7 @@ navigator.plugins is OK
 navigator.product is OK
 navigator.productSub is OK
 navigator.requestMediaKeySystemAccess() is OK
+navigator.standalone is OK
 navigator.storage is OK
 navigator.userActivation is OK
 navigator.userAgent is OK
diff --git a/LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt b/LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt
@@ -34,6 +34,7 @@ navigator.setAppBadge() is OK
 navigator.setLoggedIn() is OK
 navigator.setLoggedOut() is OK
 navigator.share() is OK
+navigator.standalone is OK
 navigator.storage is OK
 navigator.userActivation is OK
 navigator.userAgent is OK
@@ -75,6 +76,7 @@ navigator.setAppBadge() is OK
 navigator.setLoggedIn() is OK
 navigator.setLoggedOut() is OK
 navigator.share() is OK
+navigator.standalone is OK
 navigator.storage is OK
 navigator.userActivation is OK
 navigator.userAgent is OK
diff --git a/LayoutTests/platform/mac/fast/dom/navigator-detached-no-crash-expected.txt b/LayoutTests/platform/mac/fast/dom/navigator-detached-no-crash-expected.txt
@@ -23,6 +23,7 @@ navigator.productSub is OK
 navigator.requestMediaKeySystemAccess() is OK
 navigator.sendBeacon() threw err TypeError: Not enough arguments
 navigator.serviceWorker is OK
+navigator.standalone is OK
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
@@ -49,6 +50,7 @@ navigator.productSub is OK
 navigator.requestMediaKeySystemAccess() is OK
 navigator.sendBeacon() threw err TypeError: Not enough arguments
 navigator.serviceWorker is OK
+navigator.standalone is OK
 navigator.userAgent is OK
 navigator.vendor is OK
 navigator.vendorSub is OK
diff --git a/Source/WTF/wtf/PlatformEnableCocoa.h b/Source/WTF/wtf/PlatformEnableCocoa.h
@@ -474,7 +474,7 @@
 #define ENABLE_MOUSE_CURSOR_SCALE 1
 #endif
 
-#if !defined(ENABLE_NAVIGATOR_STANDALONE) && PLATFORM(IOS_FAMILY)
+#if !defined(ENABLE_NAVIGATOR_STANDALONE)
 #define ENABLE_NAVIGATOR_STANDALONE 1
 #endif
 
diff --git a/Source/WebCore/page/Navigator.cpp b/Source/WebCore/page/Navigator.cpp
@@ -350,7 +350,7 @@ bool Navigator::cookieEnabled() const
     return page->cookieJar().cookiesEnabled(*document);
 }
 
-#if PLATFORM(IOS_FAMILY)
+#if ENABLE(NAVIGATOR_STANDALONE)
 
 bool Navigator::standalone() const
 {
diff --git a/Source/WebCore/page/Navigator.h b/Source/WebCore/page/Navigator.h
@@ -53,7 +53,7 @@ class Navigator final : public NavigatorBase, public ScriptWrappable, public Loc
     bool canShare(Document&, const ShareData&);
     void share(Document&, const ShareData&, Ref<DeferredPromise>&&);
     
-#if PLATFORM(IOS_FAMILY)
+#if ENABLE(NAVIGATOR_STANDALONE)
     bool standalone() const;
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ bool Navigator::cookieEnabled() const`
`350`	`350`	`return page->cookieJar().cookiesEnabled(*document);`
`351`	`351`	`}`
`352`	`352`
`353`		`-#if PLATFORM(IOS_FAMILY)`
	`353`	`+#if ENABLE(NAVIGATOR_STANDALONE)`
`354`	`354`
`355`	`355`	`bool Navigator::standalone() const`
`356`	`356`	`{`