Consistent environment values and url references #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aolle
reviewed
Nov 25, 2023
Collaborator
Author
|
The base image has been changed to be a JDK in stead of a JRE. One of the assignments for SQL Injection Mitigation relies on this. This was one of the failing tests when running the integration tests against the container. Also a default TZ environment setting has been added. |
Collaborator
Author
|
It all looks good now. Even with running with the changed host names: |
Closed
nbaars
pushed a commit
that referenced
this pull request
Mar 19, 2024
* organizing environment variables * Update application-webgoat.properties * Update pom.xml * test without ssl * fix docker base image and default env entries * seperate server.address from webgoat.host and webwolf.host * change base image and enable endpoint logging for docker as well * change README * change README * make integration test able to verify against alternative host names * use dynamic ports and remove system println
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request to the WebGoat!
With these changes the application will work in java or as docker mode in the same way.
Please take a look at this and let me know what you think.
I'll need to add an extra commit to update some README. But the default will still be the same.
I tested with running in docker and executing the integration tests and this gave only two failing tests. So I'll take another close look at that