Repository navigation
Update WASIp2 bindings to 0.2.12, use exit-with-code - #860
Merged
Merged
Conversation
Unblocked now that 0.2.12 is being used. Closes WebAssembly#859
alexcrichton
marked this pull request as ready for review
August 3, 2026 14:40
dicej
approved these changes
Aug 6, 2026
krig
added a commit
to GramEditor/gram
that referenced
this pull request
Nov 14, 2026
… (#737) Still not entirely clear on _why_ this breaks, but my theory is that when compiling Wasm extensions now, the extensions end up using WASI 0.2.12 instead of 0.2.0, which adds exit-with-code, and the older wasmtime loader couldn't handle it. See WebAssembly/wasi-libc#860 Upgrading wasmtime to 48.0.8 seems to solve the issue at least. Ended up upgrading a bunch of other things as well. The most recent tree-sitter release (0.27.2) is built with 48.0.8 so that was the most recent version that could be upgraded to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far wasi-libc has never updated its wasip2 bindings, and I feel it's about time this is done. This is used to get access to exit-with-code. Users needing to use the older version of WASIp2 can continue to use historical versions of wasi-libc/wasi-sdk, much the same as needing to use an older LLVM version.