-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use __heap_base by dlmalloc #114
Use __heap_base by dlmalloc #114
Conversation
if (!is_initialized(gm)) { | ||
try_init_allocator(); | ||
} | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it work to call this from within init_mparams
instead? That way it'd get called for all entrypoints, not just malloc
.
In that case, it shouldn't do ensure_initialization
itself, but just do its work after init_mparams
has done its work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I've though about it, but there are some clues:
ensure_initialization
is used for mspace also (mspace is like arena in ptmalloc for different continuous space of allocations). At now, mspace is disabled, but if someone want to enable it, there will some unobvious problems. And it is logically incorrect.- Currently,
ensure_initialization
is disabled indlmalloc
, because it is inside#if USE_LOCKS
that is also disabled. And it is called intosys_alloc
. But for our purpose it is important to have it initialized before main logic of chunk choosing indlmalloc
being called. => in case ofensure_initialization
we will need two augmentation (intoensure_initialization
anddlmalloc
) instead of one in current case. - On the other side this initialization into
dlmalloc
seems correct, because other entry points (realloc
,calloc
) in all important CFG paths will call it before any chunk manipulation. The only exception here isfree
, but it is UB to callfree
without any previousmalloc
.
So, yes, it possible to move top chunk initialization into ensure_initialization
, but it seems that it is better leave it as now.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into that! I think what you have right now looks like a reasonable approach then.
Merging; thanks for implementing this! |
And mimalloc is on the way :) |
Force dlmalloc to use free memory between __heap_base and initial. Some details described here.