This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Delete file locking methods from interface#136
Merged
sunfishcode merged 2 commits intomainfrom Oct 31, 2023
Merged
Conversation
added 2 commits
October 24, 2023 16:18
We believe there is value in these lock methods for some applications (e.g. sqlite), but for the sake of shipping Preview 2, we don't have time to make and test a a cross platform implementation of these in two separate engines at this time. This is in part because some additional design work is required to integrate the blocking lock functions with pollable. These functions may come back as part of an additional filesystem interface in a post Preview 2 patch version 0.2.n, or in Preview 3 or beyond. Until then, their design is still in the git history.
77 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We believe there is value in these lock methods for some applications
(e.g. sqlite), but for the sake of shipping Preview 2, we don't have
time to make and test a cross platform implementation of these in two
separate engines at this time. This is in part because some additional
design work is required to integrate the blocking lock functions with
pollable.These functions may come back as part of an additional filesystem
interface in a post Preview 2 patch version 0.2.n, or in Preview 3 or
beyond. Until then, their design is still in the git history.