Conversation
sbc100
force-pushed
the
update_testsuite_table64
branch
7 times, most recently
from
2e01072 to
2449a08
Compare
|
Gentle ping.. |
src/c-writer.cc
Outdated
| snprintf(buf, sizeof(buf), "%.17g", Bitcast<double>(f64_bits)); | ||
| // Append .0 to if sprint didn't include a decimal point. | ||
| // Works around https://github.com/WebAssembly/wabt/issues/2422 | ||
| if (!strchr(buf, '.') && !strchr(buf, '+')) { |
There was a problem hiding this comment.
This avoids adding .0 to constants that look like 1e+20
There was a problem hiding this comment.
but that has a . already, do you mean like 1e-100?
There was a problem hiding this comment.
Updated to look for e instead, and added a comment.
|
I am totally swamped right now but will get to this asap (probably Friday evening). Sorry for delay. |
sbc100
force-pushed
the
update_testsuite_table64
branch
from
2449a08 to
20983a7
Compare
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
can you update the commit message to also cover what's happening with the tests (e.g. EH etc)
sbc100
force-pushed
the
update_testsuite_table64
branch
from
20983a7 to
818e4ae
Compare
See WebAssembly/memory64#51 Includes workaround for #2422
sbc100
force-pushed
the
update_testsuite_table64
branch
from
818e4ae to
e2a0cdf
Compare
Oops, good catch I didn't actually mean to delete those files. I took care of that already in #2416 |
| Result OnCallIndirect(const TypeVector& param_types, | ||
| const TypeVector& result_types); | ||
| const TypeVector& result_types, | ||
| const Limits& table_limits); |
There was a problem hiding this comment.
does OnReturnCallIndirect need the same modification?
There was a problem hiding this comment.
Most likely. I guess the test suite is lacking there?
5 participants
See WebAssembly/memory64#51
Includes a work around for #2388