[test] Update testsuite and corresponding update to comment parser#2416
Merged
[test] Update testsuite and corresponding update to comment parser#2416
Conversation
sbc100
force-pushed
the
update_testsuite2
branch
4 times, most recently
from
ea2e1ac to
feed7be
Compare
sbc100
commented
May 9, 2024
Member
Author
|
I'd like to land this change soon(ish) since its currently blocking the next roll which is introduces table64. |
The main change here is because `comments.wast` was updated to include a "quoted" module at the top level. Previously quoted modules had only been used as part of invalid or malformed assertion expressions.
Member
Author
|
@dschuff ptal |
Member
|
Can you clarify in the commit message that there is also a functional change for the wast parsing? |
dschuff
approved these changes
May 13, 2024
sbc100
changed the title
This was referenced May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change here is because
comments.wastwas updated to include a "quoted" module at the top level.Previously quoted modules had only been used as part of invalid or malformed assertion expressions.
I've also added copies of the lagacy exception handling tests that were removed from the testsuite repo.
These can be removed from wabt once the testsuite gets updated again. See WebAssembly/testsuite#81