c-writer.cc: represent float consts as integer literals#2389
Open
c-writer.cc: represent float consts as integer literals#2389
Conversation
keithw
force-pushed
the
w2c-raw-float-consts
branch
from
c35eaae to
54862c8
Compare
keithw
force-pushed
the
w2c-raw-float-consts
branch
from
a82fd4e to
bf9bd7b
Compare
keithw
force-pushed
the
w2c-raw-float-consts
branch
from
bf9bd7b to
508ee9e
Compare
Collaborator
|
it would be nice to get this merged... |
sbc100
approved these changes
May 3, 2024
keithw
force-pushed
the
w2c-raw-float-consts
branch
from
508ee9e to
d26dccd
Compare
Collaborator
|
presumably this can be closed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2388 by representing float constants as reinterpretations of an integer. This seems a bit safer than using a decimal
%.9gor%.17gliteral, and allows us to remove some special-case handling of NaNs, infinity, and negative zero. It does bloat the output a bit (we could shortenf64_reinterpret_i64to something likef64iwhich would help a little).wasm2c (on MSVC) now passes the new proposed testcases (https://github.com/WebAssembly/wabt/actions/runs/7864206734/job/21455684596 vs. https://github.com/WebAssembly/wabt/actions/runs/7864260678/job/21455793263).