Add paragraph describing consistency using fpenv #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Mar 24, 2021
sunfishcode
reviewed
Mar 24, 2021
tlively
reviewed
Mar 24, 2021
sunfishcode
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Looks good, thanks! And thanks to @tlively for the key idea that made it much simpler!
ngzhian
commented
Mar 24, 2021
| @@ -37,6 +37,77 @@ Example of some instructions we would like to add: | |||
| - Relaxed Swizzle (implementation defined out of bounds behavior) | |||
| - Relaxed Rounding Q-format Multiplication (optional saturation) | |||
|
|
|||
| ### Consistency | |||
|
|
|||
| This proposal introduces non-deterministic instructions - given the same | |||
There was a problem hiding this comment.
I think "non-deterministic instructions" here (and one more below) might have to change to something like "hardware-dependent instructions", because we have the section below about how the non-determinism is encapsuated in fpenv, making instructions deterministic. It can be a bit confusing.
tlively
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.