Fill in Overview.md#4
Merged
Merged
Conversation
This fills in `Overview.md` with content from the design issue, CG presentation, and subsequent discussions. It tentatively specifies that custom page sizes must be a power of two between 1 and 64KiB. It is worth noting, however, that there is still somewhat active discussion surrounding what the exact values allowed should be. Powers of two seems like the option with the most support currently. It is also a superset of the other options so, should we decide to restrict custom page sizes to only the values 1 and 64KiB in the future, for example, it should be an easy migration. See #2 for more details. There is a section that summarizes the discussion in #3. I think we've resolved the toolchain-related open questions we've thought of thus far, so I will go ahead and say that this commit Fixes #3 Finally, there is a new section on binary encoding. I have not attempted to sketch this out yet. I will open a dedicated issue for discussing this subject.
Collaborator
Author
|
Here is the rendered I'll leave this PR open for a few days for folks to comment on it and provide any feedback they have before merging. |
Collaborator
Author
Opened #5 for this discussion |
Collaborator
Author
Looks like there is not any substantive feedback on this overview document, so I'll go ahead and merge it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fills in
Overview.mdwith content from the design issue, CG presentation, and subsequent discussions.It tentatively specifies that custom page sizes must be a power of two between 1 and 64KiB. It is worth noting, however, that there is still somewhat active discussion surrounding what the exact values allowed should be. Powers of two seems like the option with the most support currently. It is also a superset of the other options so, should we decide to restrict custom page sizes to only the values 1 and 64KiB in the future, for example, it should be an easy migration. See #2 for more details.
There is a section that summarizes the discussion in #3. I think we've resolved the toolchain-related open questions we've thought of thus far, so I will go ahead and say that this commit
Fixes #3
Finally, there is a new section on binary encoding. I have not attempted to sketch this out yet. I will open a dedicated issue for discussing this subject.