Skip to content

Binary format: Don't emit empty Memory sections #5145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kripken merged 3 commits into from
Oct 17, 2022
Merged

Binary format: Don't emit empty Memory sections #5145

kripken merged 3 commits into from
Oct 17, 2022

Conversation

@kripken
Copy link
Member

@kripken kripken commented Oct 17, 2022

If the only memories are imported, we don't need the section. We were already
doing that for tables, functions, etc.

The binary testcase here is this (in a binary that has no Memory section):

(module
 (type $none_=>_i32 (func (result i32)))
 (import "a" "b" (memory $mimport$0 0))
 (export "test" (func $0))
 (func $0 (result i32)
  (i32.load
   (i32.const 10)
  )
 )
)

Noticed here: paritytech/substrate#12280 (comment)

@kripken kripken requested review from aheejin and ashleynh October 17, 2022 19:08
@kripken kripken enabled auto-merge (squash) October 17, 2022 20:17
@kripken kripken merged commit a60a716 into main Oct 17, 2022
@kripken kripken deleted the only.imported.memory branch October 17, 2022 20:47
@kripken kripken mentioned this pull request Oct 17, 2022
Merged
@brson brson mentioned this pull request Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashleynh ashleynh ashleynh approved these changes

@aheejin aheejin Awaiting requested review from aheejin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kripken @ashleynh