[Test] Fix socket test on macos. (#2555)

MediosZ · web-flow · commit 9978a74e9c9a · 2023-06-15T17:37:58.000+08:00
* [Test] Fix socket test on macos.

Signed-off-by: Tricster &lt;mediosrity@gmail.com&gt;

* [CI] Turn on verbose log on macOS.

Signed-off-by: Tricster &lt;mediosrity@gmail.com&gt;

* [CI] Inspect return value.

Signed-off-by: Tricster &lt;mediosrity@gmail.com&gt;

* [Test] Statically cast int32 to bool on macOS.

Signed-off-by: Tricster &lt;mediosrity@gmail.com&gt;

* [CI] Add debug info.

Signed-off-by: Tricster &lt;mediosrity@gmail.com&gt;

* [Test] Remove reinterpret_cast from uint8_t* to bool*

Signed-off-by: Tricster &lt;mediosrity@gmail.com&gt;

* [CI] Add full test on macOS.

Signed-off-by: Tricster &lt;mediosrity@gmail.com&gt;

* [Test] Remove unneeded line.

Signed-off-by: Tricster &lt;mediosrity@gmail.com&gt;

---------

Signed-off-by: Tricster &lt;mediosrity@gmail.com&gt;
diff --git a/.github/workflows/reusable-build-on-macos.yml b/.github/workflows/reusable-build-on-macos.yml
@@ -50,13 +50,7 @@ jobs:
         run: |
           export DYLD_LIBRARY_PATH="$(pwd)/build/lib/api:$DYLD_LIBRARY_PATH"
           cd build
-          ctest -E wasiSocketTests
-      - name: Test WasmEdge (continue on error)
-        continue-on-error: true
-        run: |
-          export DYLD_LIBRARY_PATH="$(pwd)/build/lib/api:$DYLD_LIBRARY_PATH"
-          cd build
-          ctest -R wasiSocketTests
+          ctest
       - name: Create package tarball
         run: |
           cmake --build build --target package
diff --git a/test/host/socket/wasi_socket.cpp b/test/host/socket/wasi_socket.cpp
@@ -995,7 +995,8 @@ TEST(WasiSockTest, SockOpt) {
                        Errno);
 
     EXPECT_EQ(Errno[0].get<int32_t>(), __WASI_ERRNO_SUCCESS);
-    EXPECT_TRUE(*MemInst.getPointer<const int32_t *>(ResBufPtr));
+    EXPECT_TRUE(
+        static_cast<bool>(*MemInst.getPointer<decltype(&Opt)>(ResBufPtr)));
 
     WasiFdClose.run(CallFrame, std::array<WasmEdge::ValVariant, 1>{Fd}, Errno);
     EXPECT_EQ(Errno[0].get<int32_t>(), __WASI_ERRNO_SUCCESS);
