2019 10 windows utf8 #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop boost::scoped_array and simplify the code. TCHAR should be defined as wchar_t if UNICODE is defined. So we can use .toStdWString().c_str() to get wchar_t C-style string. Backports bitcoin#13734
Backports bitcoin#13862 boost::interprocess::file_lock cannot open the files that contain characters which cannot be parsed by the user's code page on Windows.
Backports bitcoin#13877 Imbue fs::path with std::codecvt_utf8_utf16 at SetupEnvironment(), so that default string encoding will be utf-8 inside fs::path.
Backports bitcoin@2a5f574 Abstracts away how a path is opened to a `FILE*`. Reduces the number of places where path is converted to a string for anything else but printing.
Backports bitcoin#13883 Create a new class WinCmdLineArgs when building for Windows. It converts all command line arguments to utf8 string.
Backports bitcoin#13886 Use unicode string to call commans
utf-8 on Windows Backports bitcoin#14192
9813f61f5 Merge #7: Make {v}snprintf definition dependent on _MSC_VER a3ae6072a Make {v}snprintf definition dependent on _MSC_VER f545dfabf Merge PIVX-Project#18: Use utf-8 to decode filename f8e797a05 Use utf-8 to decode filename 2fc114812 Merge #14: Fixes to allow building with msvc. 524b7e36a Merge PIVX-Project#19: Increase maximum read-only mmap()s used from 1000 to 4096 on 64-bit systems 4874cb8d3 Increase maximum number of read-only mmap()s used from 1000 to 4096 on 64 bit systems. d6eab9313 Fixes to allow building with msvc. git-subtree-dir: src/leveldb git-subtree-split: 9813f61f569fdb154ed5d8cd319202a1b7347291
Warrows
force-pushed
the
2019-10_windows-utf8
branch
from
16b27a0 to
d523bf9
Compare
Warrows
force-pushed
the
2019-10_windows-utf8
branch
from
d523bf9 to
6ee0384
Compare
Warrows
added a commit
that referenced
this pull request
Nov 22, 2019
9813f61f5 Merge #7: Make {v}snprintf definition dependent on _MSC_VER a3ae6072a Make {v}snprintf definition dependent on _MSC_VER f545dfabf Merge PIVX-Project#18: Use utf-8 to decode filename f8e797a05 Use utf-8 to decode filename 2fc114812 Merge #14: Fixes to allow building with msvc. 524b7e36a Merge PIVX-Project#19: Increase maximum read-only mmap()s used from 1000 to 4096 on 64-bit systems 4874cb8d3 Increase maximum number of read-only mmap()s used from 1000 to 4096 on 64 bit systems. d6eab9313 Fixes to allow building with msvc. git-subtree-dir: src/leveldb git-subtree-split: 9813f61f569fdb154ed5d8cd319202a1b7347291
Warrows
added a commit
that referenced
this pull request
Nov 23, 2019
9813f61f5 Merge #7: Make {v}snprintf definition dependent on _MSC_VER a3ae6072a Make {v}snprintf definition dependent on _MSC_VER f545dfabf Merge PIVX-Project#18: Use utf-8 to decode filename f8e797a05 Use utf-8 to decode filename 2fc114812 Merge #14: Fixes to allow building with msvc. 524b7e36a Merge PIVX-Project#19: Increase maximum read-only mmap()s used from 1000 to 4096 on 64-bit systems 4874cb8d3 Increase maximum number of read-only mmap()s used from 1000 to 4096 on 64 bit systems. d6eab9313 Fixes to allow building with msvc. git-subtree-dir: src/leveldb git-subtree-split: 9813f61f569fdb154ed5d8cd319202a1b7347291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.