Skip to content

Omit null label sentinels from Discogs search - #292

Merged
jakebromberg merged 1 commit into
WXYC:mainfrom
snoopuppy582:fix-omit-null-label-197
May 27, 2026
Merged

jakebromberg merged 1 commit into
WXYC:mainfrom
snoopuppy582:fix-omit-null-label-197

Conversation

@snoopuppy582

Copy link
Copy Markdown
Contributor

Fixes #197

Summary

  • omit missing-label sentinel values from Discogs strict search params
  • treat NULL, null, and empty labels as absent labels
  • add a regression test for the sentinel cases reported in the issue

Tests

  • uv run --frozen --extra dev pytest tests/unit/test_discogs_service.py::TestBuildSearchParams::test_omits_missing_label_sentinel_values -q
  • uv run --frozen --extra dev pytest tests/unit/test_discogs_service.py::TestBuildSearchParams -q
  • uv run --frozen --extra dev pytest tests/unit/test_discogs_service.py -q
  • uv run --frozen --extra dev ruff check discogs/service.py tests/unit/test_discogs_service.py

Notes

  • Kept the change limited to Discogs search parameter construction.
  • Real label values are still passed through unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

library.db label column has literal string 'NULL', forcing fuzzy fallback on every label-less row

2 participants