Fix java 14 url to point to always existing version#960
Merged
JLLeitschuh merged 2 commits intoWPIRoboticsProjects:masterfrom Feb 13, 2020
Merged
Fix java 14 url to point to always existing version#960JLLeitschuh merged 2 commits intoWPIRoboticsProjects:masterfrom
JLLeitschuh merged 2 commits intoWPIRoboticsProjects:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
============================================
+ Coverage 52.55% 52.57% +0.02%
Complexity 1 1
============================================
Files 331 331
Lines 8968 8968
Branches 569 569
============================================
+ Hits 4713 4715 +2
Misses 4049 4049
+ Partials 206 204 -2 |
SamCarlberg
reviewed
Feb 8, 2020
| args.addAll("--file-associations", propsFile.asFile.absolutePath) | ||
| } | ||
| args.addAll("--package-type", installerType.get()) | ||
| args.addAll("--type", installerType.get()) |
Member
There was a problem hiding this comment.
Why is this change necessary?
Contributor
Author
There was a problem hiding this comment.
Because they keep changing flags in jpackage. That's why we're going to a fixed version we're hosting. At least until final java 14 comes out.
JLLeitschuh
approved these changes
Feb 13, 2020
Member
JLLeitschuh
left a comment
JLLeitschuh
left a comment
There was a problem hiding this comment.
Nice work. Thanks for fixing this!!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should mean we no longer need to update the version every time oracle removes one.