Fix code generation using MatWrapper instead of Mat#942
Merged
SamCarlberg merged 1 commit intoWPIRoboticsProjects:masterfrom May 16, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
============================================
- Coverage 52.89% 52.88% -0.01%
Complexity 1 1
============================================
Files 327 327
Lines 8852 8855 +3
Branches 560 561 +1
============================================
+ Hits 4682 4683 +1
- Misses 3966 3968 +2
Partials 204 204 |
JLLeitschuh
approved these changes
Apr 20, 2019
Member
JLLeitschuh
left a comment
JLLeitschuh
left a comment
There was a problem hiding this comment.
Why aren't there tests for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code generation tests obviously need work, but this is the fix for now