Use material design theme#941
Conversation
Tweak splitpane dividers to be less intrusive
No more orphan dialogs improves UX on multi-monitor setups
|
Well, that's different. Not bad though. Is there a dark mode? Lol |
| <?import javafx.scene.layout.StackPane?> | ||
| <HBox styleClass="socket" | ||
| fx:controller="edu.wpi.grip.ui.OperationController" | ||
| fx:controller="edu.wpi.grip.ui.pipeline.OutputSocketController" |
There was a problem hiding this comment.
fx:controller is necessary, and OperationController is for controlling the UI element displaying an entire operation. OutputSocketController is more appropriate.
This also makes the file in line with InputSocket.fxml, which already uses InputSocketController as its fx:controller attribute
JLLeitschuh
left a comment
JLLeitschuh
left a comment
There was a problem hiding this comment.
LGTM after my questions are resolved.
Make undecorated instead of utility Put padding in CSS instead of FXML
|
No dark mode yet. Maybe later |
Makes it so that the default dialog size won't result in (small) scroll bars and text overruns.
Was caused by removing the stylesheet from MainWindow.fxml
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
============================================
- Coverage 52.89% 52.76% -0.13%
Complexity 1 1
============================================
Files 327 327
Lines 8852 8877 +25
Branches 560 561 +1
============================================
+ Hits 4682 4684 +2
- Misses 3966 3989 +23
Partials 204 204 |
Use a hard color border instead of a guassian shadow (which looked like a fuzzy border as well as undesirably shading the button icons)
|
@SamCarlberg can this be merged? |
JLLeitschuh
left a comment
JLLeitschuh
left a comment
There was a problem hiding this comment.
Just tried this out locally, and it works. Looks good! Nice work! Sorry for taking so long to merge.
3 participants
Closes #664
Makes dialogs appear centered on the main window, instead of centered on the primary screen (which was a problem on multi-monitor setups)
Screenshots
Empty window
Pipeline
Step detail
Palette
Analysis dialog
Deploy dialog
For reference only, since deploy is going to be removed
Exception alert
