Skip to content

Comments

Show decimals on range sliders with low bounds#931

Merged
SamCarlberg merged 1 commit intoWPIRoboticsProjects:masterfrom
SamCarlberg:fix/slider-truncation
Mar 25, 2019
Merged

Show decimals on range sliders with low bounds#931
SamCarlberg merged 1 commit intoWPIRoboticsProjects:masterfrom
SamCarlberg:fix/slider-truncation

Conversation

@SamCarlberg
Copy link
Member

A slider from 0-1 will show values to 2 decimal places ("0.01 - 0.07") instead of "1 - 1"

Fixes #927

e.g. a slider from 0-1 will show values to 2 decimal places ("0.01 - 0.07") instead of "1 - 1"
@SamCarlberg SamCarlberg added location: ui type: bugfix Fixes one or more open bugs labels Mar 25, 2019
@codecov-io
Copy link

Codecov Report

Merging #931 into master will decrease coverage by 0.02%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   54.49%   54.47%   -0.03%     
==========================================
  Files         304      304              
  Lines        8318     8325       +7     
  Branches      535      537       +2     
==========================================
+ Hits         4533     4535       +2     
- Misses       3588     3591       +3     
- Partials      197      199       +2

Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SamCarlberg SamCarlberg merged commit a2c3264 into WPIRoboticsProjects:master Mar 25, 2019
@SamCarlberg SamCarlberg deleted the fix/slider-truncation branch March 25, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

location: ui type: bugfix Fixes one or more open bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants