Initialize sources loaded from save file before firing event#914
Merged
SamCarlberg merged 2 commits intoWPIRoboticsProjects:masterfrom Jan 28, 2019
Merged
Conversation
Fixes a problem with video file sources loaded from a save file not having play/pause and scrubber controls
JLLeitschuh
reviewed
Jan 23, 2019
core/src/main/java/edu/wpi/grip/core/serialization/SourceConverter.java
Outdated
Show resolved
Hide resolved
JLLeitschuh
requested changes
Jan 23, 2019
Member
JLLeitschuh
left a comment
JLLeitschuh
left a comment
There was a problem hiding this comment.
Any way to add a test for this to ensure we don't have any regressions?
Codecov Report
@@ Coverage Diff @@
## master #914 +/- ##
==========================================
- Coverage 54.5% 54.48% -0.03%
==========================================
Files 304 304
Lines 8318 8318
Branches 535 535
==========================================
- Hits 4534 4532 -2
- Misses 3587 3588 +1
- Partials 197 198 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a problem with video file sources loaded from a save file not having play/pause and scrubber controls
Closes #913