Skip to content

Comments

Update xstream version to 1.4.10 to fix security issue#885

Merged
JLLeitschuh merged 1 commit intoWPIRoboticsProjects:masterfrom
JLLeitschuh:fix/JLL/xstream-version
Mar 21, 2018
Merged

Update xstream version to 1.4.10 to fix security issue#885
JLLeitschuh merged 1 commit intoWPIRoboticsProjects:masterfrom
JLLeitschuh:fix/JLL/xstream-version

Conversation

@JLLeitschuh
Copy link
Member

@JLLeitschuh JLLeitschuh commented Feb 20, 2018

No description provided.

@SamCarlberg
Copy link
Member

SamCarlberg commented Feb 20, 2018

What security issue?

@JLLeitschuh
Copy link
Member Author

JLLeitschuh commented Feb 20, 2018

It should basically make our version eye badge no longer show "insecure".
https://www.versioneye.com/java/com.thoughtworks.xstream:xstream/1.4.9

@codecov-io
Copy link

codecov-io commented Feb 20, 2018 •
edited
Loading

Codecov Report

Merging #885 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #885      +/-   ##
============================================
- Coverage     52.27%   51.74%   -0.54%     
+ Complexity     1163     1158       -5     
============================================
  Files           248      247       -1     
  Lines          7962     7812     -150     
  Branches        533      533              
============================================
- Hits           4162     4042     -120     
+ Misses         3621     3590      -31     
- Partials        179      180       +1

@AustinShalit
Copy link
Member

AustinShalit commented Feb 20, 2018

Change log for reference: http://x-stream.github.io/changes.html

Will test when I get home

@JLLeitschuh
Copy link
Member Author

JLLeitschuh commented Mar 21, 2018

I can't merge this without one person's approval. (I mean I can if I want to disable the setting) but I don't want to.

AustinShalit
AustinShalit approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@AustinShalit AustinShalit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to merge this but also don't know what the side affects are. Testing seems to not break anything though.

@JLLeitschuh JLLeitschuh merged commit d38c920 into WPIRoboticsProjects:master Mar 21, 2018
@JLLeitschuh JLLeitschuh deleted the fix/JLL/xstream-version branch March 21, 2018 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AustinShalit AustinShalit AustinShalit approved these changes

@SamCarlberg SamCarlberg Awaiting requested review from SamCarlberg

Assignees

No one assigned

Labels

type: build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JLLeitschuh @SamCarlberg @codecov-io @AustinShalit