Make the preloader have a fancy background#843
Merged
JLLeitschuh merged 3 commits intoWPIRoboticsProjects:masterfrom May 5, 2017
Merged
Make the preloader have a fancy background#843JLLeitschuh merged 3 commits intoWPIRoboticsProjects:masterfrom
JLLeitschuh merged 3 commits intoWPIRoboticsProjects:masterfrom
Conversation
Remove the progress bar from the preloader as well
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
=========================================
Coverage 52.35% 52.35%
Complexity 1134 1134
=========================================
Files 240 240
Lines 7724 7724
Branches 526 526
=========================================
Hits 4044 4044
Misses 3494 3494
Partials 186 186Continue to review full report at Codecov.
|
Member
|
For documentational purposes can you include a GIF or a screen shot? |
…ects#832 Small improvements to hex grid placement, no more weird boders
Member
|
Make sure the tests are working and then let me know when this works. |
Member
|
This looks like the tests passed. Is this good to be merged? |
Member
Author
|
It has been for over a month |
JLLeitschuh
approved these changes
May 5, 2017
Member
|
I know we just merged this but I am finding it hard to read "GRIP" on the new loader. Should we lighten up the logo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the progress bar from the preloader as well