Fix various issues with generated C++#798
Merged
SamCarlberg merged 7 commits intoWPIRoboticsProjects:masterfrom Jan 30, 2017
Merged
Fix various issues with generated C++#798SamCarlberg merged 7 commits intoWPIRoboticsProjects:masterfrom
SamCarlberg merged 7 commits intoWPIRoboticsProjects:masterfrom
Conversation
Codecov Report@@ Coverage Diff @@
## master #798 +/- ##
============================================
- Coverage 52.51% 52.45% -0.06%
- Complexity 0 1133 +1133
============================================
Files 240 240
Lines 7705 7708 +3
Branches 742 522 -220
============================================
- Hits 4046 4043 -3
- Misses 3475 3480 +5
- Partials 184 185 +1Continue to review full report at Codecov.
|
Member
|
Have you run the C++ code gen tests? |
Member
Author
|
@JLLeitschuh C++ code gen tests are broken. But I've been generating code into an FRC project and compiling it there. |
All public C++ functions should be PascalCase now
JLLeitschuh
approved these changes
Jan 30, 2017
Member
JLLeitschuh
left a comment
JLLeitschuh
left a comment
There was a problem hiding this comment.
Get this shipped to the teams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #797