Improve logging#790
Conversation
Gets rid of all the annoying JavaFX and injection crap from the logs
| private static final Logger logger = Logger.getLogger(EventLogger.class.getName()); | ||
|
|
||
| @Subscribe | ||
| public void eventPosted(LoggableEvent event) { |
There was a problem hiding this comment.
Do you want to make it so that this event can be handled by multiple threads simultaneously?
If so you need to add that other annotation (not sure what its called)
There was a problem hiding this comment.
@AllowConcurrentEvents I think
There was a problem hiding this comment.
I'm not going to add the @AllowConcurrentEvents annotation; the event bus is synchronous so only one event will be posted at a time anyway.
Current coverage is 52.51% (diff: 66.66%)@@ master #790 diff @@
==========================================
Files 238 240 +2
Lines 7668 7705 +37
Methods 0 0
Messages 0 0
Branches 739 742 +3
==========================================
+ Hits 3996 4046 +50
+ Misses 3488 3475 -13
Partials 184 184
|
| .toString(); | ||
| } | ||
|
|
||
| private static String simpleString(Socket<?> socket) { |
There was a problem hiding this comment.
Why is this method in the connection class instead of a helper method on the Socket object??
Throw this in a default method on the Socket interface.
JLLeitschuh
left a comment
JLLeitschuh
left a comment
There was a problem hiding this comment.
Do the thing with @AllowConcurrentEvents and move the simple string method to the class it's creating a simple string on.
SamCarlberg
force-pushed
the
better-logging
branch
from
614f9a7 to
aaafcb5
Compare
3 participants
The current logs are about 1100 lines of debugging stuff from guava and about zero lines of stuff from GRIP. This PR reverses that situation.